fix: copy dicom inputs before running dcm2niix#60
Open
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Open
fix: copy dicom inputs before running dcm2niix#60AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mentors! 👋
This PR addresses the DICOM conversion flow bug reported in Issue #40.
The Problem:
DICOM2NiFTIConverter.convert()created a temporary directory and then immediately checked whether it was empty, but it never copied the incoming DICOM files into that directory. As a result, the converter returnedNo DICOM files found.beforedcm2niixcould ever run.The Solution:
Copy Inputs Into Temp Directory: Each uploaded DICOM file is now copied into the converter's temporary working directory before metadata extraction and subprocess execution.
Preserve Existing Metadata Logic: The existing
SeriesNumberandlRepetitionsextraction logic is kept intact.Regression Coverage: Added a focused converter test that verifies the temporary input directory is populated,
subprocess.run()is reached, and the generated JSON gets the expectedlRepetitionsvalue.Validation:
Ran
python -m pytest package/src/pyaslreport/tests/test_dicom_to_nifti_converter.py -qand the new converter regression test passed.Fixes #40